Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to specify the identity for signing #1610

Merged
merged 2 commits into from
Apr 4, 2022

Conversation

Jamstah
Copy link
Contributor

@Jamstah Jamstah commented Mar 30, 2022

This enables pushing to registries where the push and pull uris may be
different, for example where pushed images are mirrored to a read only
replica for distribution.

Closes #1588

@Jamstah Jamstah marked this pull request as draft March 30, 2022 16:57
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Please update also docs/skopeo-copy.1.md and completions/bash/skopeo.

cmd/skopeo/copy.go Outdated Show resolved Hide resolved
cmd/skopeo/copy.go Outdated Show resolved Hide resolved
cmd/skopeo/copy.go Outdated Show resolved Hide resolved
@Jamstah
Copy link
Contributor Author

Jamstah commented Mar 30, 2022

@mtrmac apologies, I opened this pr too soon and was late to switch to draft!

Thanks for the comments so far, will make sure they all go in for when its ready for review.

@Jamstah Jamstah force-pushed the sign-identity branch 2 times, most recently from 3802bfc to b211b57 Compare March 30, 2022 20:11
Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
This enables pushing to registries where the push and pull uris may be
different, for example where pushed images are mirrored to a read only
replica for distribution.

Closes containers#1588

Signed-off-by: James Hewitt <james.hewitt@uk.ibm.com>
@Jamstah Jamstah marked this pull request as ready for review March 30, 2022 21:02
@Jamstah Jamstah requested a review from mtrmac March 30, 2022 21:02
Copy link
Collaborator

@mtrmac mtrmac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@mtrmac mtrmac merged commit 15b3811 into containers:main Apr 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support copy --sign-by where the needed docker reference and push domain are different.
2 participants