Move copy implementation into containers/image #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
copy
branch
4 times, most recently
from
cf9b0e6
to
448db98
Compare
|
Reconstructed to depend only on #180 (and the containers/image PR). |
This is necessary to be able to check out a branch named "clone", otherwise we get > fatal: ambiguous argument 'copy': both revision and filename
|
#180 merged |
|
Yeah, this contains a few changes which are not purely re-vendoring + API changes so I was thinking you might want to give this a quick look over. |
|
… oops, I didn’t push the rebased branch. Pushed now, I will revendor to containers/image:master in the mean time. |
|
I'll take a look sure! |
|
LGTM, merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in containers/image#56 and updates the API usage.
Depends on way too much pending work, I will rebase as necessary.