Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skopeo fetcher #2

Closed
wants to merge 3 commits into from
Closed

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Mar 8, 2016

add the command layers to skopeo. Code copied from cifetch.

@runcom
Copy link
Member

runcom commented Mar 8, 2016

Things left to do there:

  • sync with upstream docker code (since there's some change in vendor/ here) - I'll do it asap
  • add smoke tests under integration/ for the layer command - @giuseppe?
  • add smoke tests under integration/ for the inspect command
  • update README for the layer command

Current tests pass, thanks @giuseppe - current code is fine right now but it will undergo an heavy refactor to externalize registries' interactions (/cc @vbatts)

@giuseppe
Copy link
Member Author

giuseppe commented Mar 8, 2016

runcom, I resync the file in vendor/ from github.com/docker/docker/pkg/homedir/homedir.go

@runcom
Copy link
Member

runcom commented Mar 8, 2016

runcom, I resync the file in vendor/ from github.com/docker/docker/pkg/homedir/homedir.go

this has to be done with godep ensuring all deps are fine and in sync

@giuseppe
Copy link
Member Author

giuseppe commented Mar 8, 2016

ok thanks, just I hit this issue when I use godep:

# github.com/docker/docker/cliconfig
../../docker/docker/cliconfig/config.go:104: authConfig.Email undefined (type types.AuthConfig has no field or method Email)
# github.com/docker/docker/image/v1
../../docker/docker/image/v1/imagev1.go:34: v1Image.ContainerConfig.Cmd.Slice undefined (type strslice.StrSlice has no field or method Slice)
godep: exit status 2

@runcom
Copy link
Member

runcom commented Mar 8, 2016

wait wait, I did a huge mistake, sorry, the script to vendor deps is in ./hack/vendor.sh sorry about this 😢

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Copy code from cifetch

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

giuseppe commented Mar 8, 2016

fixed in the version here ⬆️

@rhatdan
Copy link
Member

rhatdan commented Mar 8, 2016

I would like to change default skopeo imediately to use the inspect command so that we don't release skopeo into a supported release using the current CLI. Then you can continue to work on this enhancement to skopeo in time.

@runcom
Copy link
Member

runcom commented Mar 8, 2016

@rhatdan I'll fix and merge this on top of what @giuseppe did hopefully today or tomorrow

@runcom runcom mentioned this pull request Mar 9, 2016
@runcom runcom closed this Mar 9, 2016
lumjjb pushed a commit to lumjjb/skopeo that referenced this pull request Aug 19, 2019
tych0 pushed a commit to tych0/skopeo that referenced this pull request Aug 28, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants