Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update c/image for golang.org/x/exp #2064

Merged
merged 1 commit into from Aug 3, 2023

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Aug 2, 2023

go get github.com/containers/image/v5@main
go mod tidy && go mod vendor

This updates c/image with a new version of x/exp. That package has changed API in an incompatible way, so just bumping x/exp (as in #2060 ) would break Skopeo builds.

This updates both c/image and x/exp in lockstep (and nothing needs updating in Skopeo itself for the x/exp breakage).

> go get github.com/containers/image/v5@main
> go mod tidy && go mod vendor

This updates c/image with a new version of x/exp.
That package has changed API in an incompatible way,
so just bumping x/exp (as in containers#2060 )
would break Skopeo builds.

This updates both c/image and x/exp in lockstep (and nothing
needs updating in Skopeo itself for the x/exp breakage).

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg vrothberg merged commit 575f411 into containers:main Aug 3, 2023
22 checks passed
@mtrmac mtrmac deleted the c-image-for-x-exp branch August 3, 2023 18:05
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants