Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cirrus: Remove multi-arch skopeo image builds #2093

Merged
merged 1 commit into from Sep 13, 2023

Conversation

cevich
Copy link
Member

@cevich cevich commented Aug 28, 2023

These jobs have been failing since early August due to technical/scripting problems. Disable/remove entirely since a fix is unlikely to be implemented anytime soon.

If anybody ever cares, I gave up trying to debug the script problem in containers/podman#19720.

@cevich
Copy link
Member Author

cevich commented Aug 28, 2023

@cevich cevich changed the title [WIP] [CI:DOCS] Cirrus: Remove multi-arch skopeo image builds [WIP] Cirrus: Remove multi-arch skopeo image builds Aug 28, 2023
@mtrmac
Copy link
Collaborator

mtrmac commented Aug 28, 2023

I’m afraid I haven’t been really paying attention to these jq failures — is resolving this a matter of days/weeks, and is this PR just to save on CI in the meantime? Or is this failure something I should have dealt with? Or is it “probably broken indefinitely”?

If it’s the last one, install.md and README.md (and other places?) will need updating. And we might need a deprecation notice… somewhere.

@cevich
Copy link
Member Author

cevich commented Aug 28, 2023

I’m afraid I haven’t been really paying attention to these jq failures — is resolving this a matter of days/weeks, and is this PR just to save on CI in the meantime?

No worries, I added a link in the PR description. Yes, I spent weeks debugging and likely weeks more are needed. It's entirely possible that future build automation will use a new script or no script at all. I haven't decided yet. In all cases, the builds can't happen in cirrus for other reasons, so might as well clobber it.

If it’s the last one

The same (probably?) jq problem was happening in all podman, buildah and skopeo build automation. So I don't think the image source or docs needs any changes at the moment.

@cevich cevich changed the title [WIP] Cirrus: Remove multi-arch skopeo image builds Cirrus: Remove multi-arch skopeo image builds Aug 28, 2023
@cevich cevich marked this pull request as ready for review August 28, 2023 20:11
@mtrmac
Copy link
Collaborator

mtrmac commented Aug 28, 2023

In all cases, the builds can't happen in cirrus for other reasons, so might as well clobber it.

ACK.

So I don't think the image source or docs needs any changes at the moment.

The other two repos don’t point at quay.io as official ways to install, AFAICS (and that makes sense, running them containerized would be much harder).

For Skopeo, eventually we need to decide if we are going to continue to provide container images (somehow), or not — and if not, the documentation needs to stop advertising them. Eventually; this is not urgent, new releases only happen every few months; but if we, after a time, ended up pointing users at year-old releases, that would not be ideal.

@cevich
Copy link
Member Author

cevich commented Aug 28, 2023

I agree. My intention is to replace the build automation. I think that's most helpful for the users. Might be a good idea to sign the images as well, but that may be a further update later on.

These jobs have been failing since early August due to
technical/scripting problems.  Disable/remove entirely since a fix
is unlikely to be implemented anytime soon.

Signed-off-by: Chris Evich <cevich@redhat.com>
@cevich
Copy link
Member Author

cevich commented Sep 13, 2023

Force-push: Rebased. This should be ready to go.

@mtrmac
Copy link
Collaborator

mtrmac commented Sep 13, 2023

README.md and install.md point at the quay.io/containers/skopeo and quay.io/skopeo container images.

I’m mildly worried about us stopping to build them, and continuing to point users at old unmaintained software. Can we leave a traceable trail, at least? Is there a WIP of the new replacement somewhere? If not, I can open a Skopeo issue to track the situation and we can link to it here.

@cevich
Copy link
Member Author

cevich commented Sep 13, 2023

Unless I'm misunderstanding something, those FQINs are all still valid. Recent images were built and pushed there manually (unless I forgot? I haven't checked). This PR just disables/removes the (broken since August) built automation. Re-implementing that is number-2 on my hot-list right behind adding a "make sure credentials can't leak" check.

@mtrmac
Copy link
Collaborator

mtrmac commented Sep 13, 2023

(I think 1.13.3 is missing (but the difference between 1.13.2 and 1.13.3 is irrelevant). Dan has also been tagging releases this week…)

Either way, I have filed #2110 , the stale bot will eventually remind me to revisit.

@mtrmac mtrmac merged commit 7482b74 into containers:main Sep 13, 2023
25 checks passed
@cevich
Copy link
Member Author

cevich commented Sep 13, 2023

Good idea. Thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants