[release-1.14] Bump google.golang.org/protobuf to v1.33.0 #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the title says. Addresses CVE-2024-24786 https://issues.redhat.com/browse/RHEL-28226 https://issues.redhat.com/browse/RHEL-28235 [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
mtrmac
reviewed
Mar 15, 2024
There was a problem hiding this comment.
The mechanism of the update LGTM. Thanks!
From a <5-minute check, it is possible that the codebase only ever invokes the marshal, not unmarshal, implementation of JSON . OTOH I can’t spend much time analyzing this right now; I’m not familiar with these subpackages; and updating is certainly the safer way to eliminate the vulnerability with fewer questions asked.
Feel free to merge after this passes tests — unless the benefits of looking deeper and possibly avoiding the update were significant.
|
Thanks @mtrmac I've always leaned towards the better safe than sorry bit on these kinds of things. I'll push it through once happy. |
|
Addresses: https://issues.redhat.com/browse/RHEL-40852 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says. Addresses CVE-2024-24786
https://issues.redhat.com/browse/RHEL-28226
https://issues.redhat.com/browse/RHEL-28235
[NO NEW TESTS NEEDED]