Vendor in non-gpgme support, and update tests and build machinery #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtrmac
force-pushed
the
openpgp
branch
2 times, most recently
from
9edc769
to
49e52f3
Compare
mtrmac
force-pushed
the
openpgp
branch
3 times, most recently
from
e1f8694
to
2f5354d
Compare
mtrmac
force-pushed
the
openpgp
branch
2 times, most recently
from
1b4938d
to
6b234c3
Compare
mtrmac
changed the title
mtrmac
force-pushed
the
openpgp
branch
3 times, most recently
from
1b7e258
to
1163319
Compare
|
👍 |
… so that any command-line overrides are respected.
Primarily vendor after merging mtrmac/image:openpgp. Then update for the SigningMechanism API change. Also skip signing tests if the GPG mechanism does not support signing. Also abort some of the tests early instead of trying to use invalid (or nil) values. The current master of image-tools does not build with Go 1.6, so keep using an older release. Also requires adding a few more dependencies of our updated dependencies.
mtrmac
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This vendors in containers/image#207 , and:
BUILDTAGSthroughout the various subroutines and helpersopenpgpbackend (which does not support signing). It would be nice to split the tests into a signing/verification part, and continuing to test verification (of signatures in fixtures), but this works for now. The core verification code hopefully has sufficient coverage incontainers/image/signature.