Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

btrfs.go args.lim.max_referenced undefined #1454

Closed
siretart opened this issue Dec 28, 2022 · 4 comments · Fixed by #1455
Closed

btrfs.go args.lim.max_referenced undefined #1454

siretart opened this issue Dec 28, 2022 · 4 comments · Fixed by #1455

Comments

@siretart
Copy link
Contributor

Compiling against newer https://github.com/containerd/btrfs (version 1.0) results in a compilation failure:

# github.com/containers/storage/drivers/btrfs
src/github.com/containers/storage/drivers/btrfs/btrfs.go:385:11: args.lim.max_referenced undefined (type _Ctype_struct_btrfs_qgroup_limit has no field or method max_referenced)

This was reported in debian as https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027116 and https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1027116

@siretart
Copy link
Contributor Author

This issue is very similar to moby/moby#44698 and seems to be triggered by an upstream change referenced here: kdave/btrfs-progs@0345143

@siretart
Copy link
Contributor Author

flouthoc added a commit to flouthoc/storage that referenced this issue Jan 1, 2023
Field name `args.lim.max_referenced` is renamed to `args.lim.max_rfer`
in newer versions.

See: https://docs.huihoo.com/doxygen/linux/kernel/3.7/structbtrfs__ioctl__qgroup__limit__args.html
PR is similar to: moby/moby#44707
Closes: containers#1454

Signed-off-by: Aditya R <arajan@redhat.com>
@flouthoc
Copy link
Collaborator

flouthoc commented Jan 1, 2023

Crun CI is blocked (containers/crun#1111) for similar reason I have created a PR.

@kdave
Copy link

kdave commented Jan 3, 2023

The change in btrfs-progs will be reverted and released in v6.1.1 so you'll probably see more build breakage until everybody updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants