Fix: relative path will result infinite loop #1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flouthoc
reviewed
Oct 19, 2021
flouthoc
reviewed
Oct 19, 2021
pkg/idtools/idtools_unix_test.go
Outdated
| @@ -163,6 +163,11 @@ func TestMkdirAs(t *testing.T) { | |||
| if err := compareTrees(testTree, verifyTree); err != nil { | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| // relative path will return an error | |||
There was a problem hiding this comment.
Same filepath.IsAbs should be a better choice right ?
chenk008
force-pushed
the
fix_infinite_loop
branch
6 times, most recently
from
5be8842
to
ff99167
Compare
Signed-off-by: chenk008 <kongchen28@gmail.com>
chenk008
force-pushed
the
fix_infinite_loop
branch
from
ff99167
to
f5815b0
Compare
|
LGTM |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storage/pkg/idtools/idtools_unix.go
Line 49 in 73df15c
Add validation to avoid it.
Signed-off-by: chenk008 kongchen28@gmail.com