Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay.get: if we're ignoring metacopy=on, ignore it when it's global #1049

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

nalind
Copy link
Member

@nalind nalind commented Oct 28, 2021

If we've determined that we need to ignore a metacopy=on mount option, ignore it when it's a globally-set option, too.

Should fix RHBZ #1979966.

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

drivers/overlay/overlay.go Outdated Show resolved Hide resolved
@nalind nalind force-pushed the mountopts-at-init branch 3 times, most recently from 56a0297 to ee3de94 Compare November 5, 2021 13:37
If we've determined that we need to ignore a metacopy=on mount option,
ignore it when it's a globally-set option, too.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

@giuseppe @rhatdan PTAL

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit d81acd8 into containers:main Nov 8, 2021
@nalind nalind deleted the mountopts-at-init branch November 8, 2021 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants