Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Clearup inheritance rules for storage.conf #1050

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented Oct 31, 2021

We have had cases where users assume that create a storage.conf file in
their home directory, will still inherit fields from the system
storage.conf files. Need to clear this up in the storage.conf file and
man page.

Fixes: containers/podman#11778

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@rhatdan rhatdan force-pushed the storage.conf branch 2 times, most recently from 29043f1 to b94ffe0 Compare October 31, 2021 09:52
@@ -1,5 +1,13 @@
# This file is is the configuration file for all tools
# that use the containers/storage library.
# that use the containers/storage library. The storage.conf file
# overrides all other storage.conf files. Container engines using the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you take the above, tweak the wording here too please

We have had cases where users assume that create a storage.conf file in
their home directory, will still inherit fields from the system
storage.conf files. Need to clear this up in the storage.conf file and
man page.

Fixes: containers/podman#11778

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan rhatdan changed the title Clearup inheritance rules for storage.conf [CI:DOCS] Clearup inheritance rules for storage.conf Nov 4, 2021
@rhatdan
Copy link
Member Author

rhatdan commented Nov 4, 2021

@TomSweeneyRedHat PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Nov 5, 2021

@saschagrunert @giuseppe @vrothberg PTAL

@rhatdan
Copy link
Member Author

rhatdan commented Nov 5, 2021

@TomSweeneyRedHat PTAL

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan rhatdan merged commit cd735e3 into containers:main Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Existence of user storage.conf (rootless) causes driver errors
4 participants