-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Clearup inheritance rules for storage.conf #1050
Conversation
29043f1
to
b94ffe0
Compare
@@ -1,5 +1,13 @@ | |||
# This file is is the configuration file for all tools | |||
# that use the containers/storage library. | |||
# that use the containers/storage library. The storage.conf file | |||
# overrides all other storage.conf files. Container engines using the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you take the above, tweak the wording here too please
We have had cases where users assume that create a storage.conf file in their home directory, will still inherit fields from the system storage.conf files. Need to clear this up in the storage.conf file and man page. Fixes: containers/podman#11778 Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@TomSweeneyRedHat PTAL |
@TomSweeneyRedHat PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
We have had cases where users assume that create a storage.conf file in
their home directory, will still inherit fields from the system
storage.conf files. Need to clear this up in the storage.conf file and
man page.
Fixes: containers/podman#11778
Signed-off-by: Daniel J Walsh dwalsh@redhat.com