Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reexec: mark us as initialized when calling initializers #1067

Merged
merged 1 commit into from
Nov 19, 2021

Conversation

nalind
Copy link
Member

@nalind nalind commented Nov 19, 2021

In cases where one of our initializers needs to itself use reexec, they shouldn't panic().

Follow-up to #1058.

In cases where one of our initializers needs to itself use reexec, they
shouldn't panic().

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Nov 19, 2021

LGTM
@giuseppe @vrothberg @saschagrunert @flouthoc PTAL

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@giuseppe giuseppe merged commit 3d53265 into containers:main Nov 19, 2021
@nalind nalind deleted the reexec-error branch November 19, 2021 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants