idtools: support libsubid 4 #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
more details here: shadow-maint/shadow#449 |
|
@giuseppe I'll do the shadow-utils rebase for Fedora rawhide, so please let me know when this patch is included there as I don't want to break anything. |
|
@ikerexxe it will take some time until the patch is propagated into the container tools |
rhatdan
reviewed
Dec 9, 2021
the functions get_subuid_ranges and get_subgid_ranges were renamed respectively to subid_get_uid_ranges and subid_get_gid_ranges in libsubid version 4. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
LGTM |
1 similar comment
|
LGTM |
|
/lgtm |
|
I am late but LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the functions get_subuid_ranges and get_subgid_ranges were renamed
respectively to subid_get_uid_ranges and subid_get_gid_ranges in
libsubid version 4.
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com