store: use system.EnsureRemoveAll to rm container #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM , EnsureRemoveAll will do the replaced retries I guess. |
|
/lgtm |
flouthoc
approved these changes
Jan 14, 2022
|
LGTM |
if the container deletion fails with the simple os.RemoveAll(path), then attempt again using system.EnsureRemoveAll(path). The difference is that system.EnsureRemoveAll(path) tries to umount eventual mounts that are keeping the directory busy. It might help with: containers/podman#11594 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
attempt-to-solve-podman-11594
branch
from
cf3e777
to
3e69d9a
Compare
|
rebased and pushed |
|
Ignoring devicemapper flake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if the container deletion fails with the simple os.RemoveAll(path),
then attempt again using system.EnsureRemoveAll(path).
The difference is that system.EnsureRemoveAll(path) tries to umount
eventual mounts that are keeping the directory busy.
It might help with: containers/podman#11594
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com