Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

archive: skip adding sockets to the tarball #1116

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

giuseppe
Copy link
Member

the tar format doesn't support sockets so avoid adding them to the tar
stream.

Closes: #1115

Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the tar format doesn't support sockets so avoid adding them to the tar
stream.

Closes: containers#1115

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

rebased

@flouthoc
Copy link
Collaborator

/lgtm
/approve

@rhatdan rhatdan merged commit 43c4bb0 into containers:main Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow-on to #1888: error committing image "tar: sockets not supported"
4 participants