overlay.Get(): default to read-only for layers in additionalStores #1123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parent layer, by virtue of being a parent layer isn't going to be modified, so default to mounting it read-only. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
When mounting a layer, if the layer in question lives in an additional store, default to mounting it read-only. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When mounting a layer, if the layer in question lives in an additional store, default to mounting it read-only, which is how we're treating the additional store's layers. If we need to generate a diff using the naive diff implementation, this will prevent errors that would crop up if we tried and failed to mount the layer read-write, per #1121.
When mounting a parent layer in
drivers.NaiveDiffDriver.Changes(), default to mounting it read-only, too, since a layer that is the basis for other layers shouldn't ever need to be mounted read-write anyway.