Remove an undocumented assumption that O_RDONLY == 0 #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
There's at least one Go platform where that is not true. Making that assumption without any warning is just a trap for future readers. Instead, just do the obviously correct thing, per the API documentation. On macOS, this compiles to _literally exactly the same binary code_. So, let the compiler be clever so that we don't have to. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
dont-be-too-clever
branch
from
29a9672
to
924ace2
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's at least one Go platform where that is not true.
Making that assumption without any warning is just a trap for future readers.
Instead, just do the obviously correct thing, per the API documentation.
On macOS, this compiles to literally exactly the same binary code.
So, let the compiler be clever so that we don't have to.