Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two misc. cleanups #1380

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Two misc. cleanups #1380

merged 2 commits into from
Oct 13, 2022

Conversation

mtrmac
Copy link
Collaborator

@mtrmac mtrmac commented Oct 10, 2022

… just to reduce the size of my branches a bit.

See individual commit messages for details. I’d be happy to split this into two PRs if desired.

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Copy link
Member

@rhatdan rhatdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rhatdan
Copy link
Member

rhatdan commented Oct 13, 2022

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

Can we install the merge bot in containers/storage? I personally do not feel comfortable clicking on the merge button.

@rhatdan rhatdan merged commit 714f4fc into containers:main Oct 13, 2022
@rhatdan
Copy link
Member

rhatdan commented Oct 13, 2022

@cevich PTAL

@mtrmac mtrmac deleted the misc branch October 13, 2022 18:39
@cevich
Copy link
Member

cevich commented Oct 13, 2022

I don't know how that bot works, @baude is the SME. Unless there are some docs somewhere on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants