Lock layers only for reading #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
... and use readAllLayerStores. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
There seems to be no reason to lock for writing. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
read-layer-lock
branch
from
695ca11
to
d498257
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only lock the primary layer store for reading in
CreateImageandLayers; I can’t see any reason for the exclusivity.Cc: @nalind in case I’m missing something, primarily in
CreateImage.