Fix locking bugs #1400
Merged
Fix locking bugs #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't immediately unlock the layer store after locking it. Luckily it only matters for additional stores. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
This is a bad bug: we wouldn't reload state from disk at all in writers. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
|
Also: Fix This is a bad bug: we wouldn't reload state from disk at all in writers. |
|
LGTM |
|
Feel free to merge. I don't feel comfortable with the 'update branch' button. |
This was referenced Oct 19, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't immediately unlock the layer store after locking it.
Luckily it only matters for additional stores.