Expose System wide config file #1405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently Podman warns when attempting to reset storage, if the system wide storage.conf file /usr/share/containers/storage.conf exists. Since distros ship this, we need to allow Podman to check if the default is the System default and therefore do not warn. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
vrothberg
reviewed
Oct 27, 2022
|
Yes there will be a change in Podman to check if the exiting storage.conf is the SystemDeffault, then don't report a warning. |
OK. I trust the code is doing the right thing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Podman warns when attempting to reset storage, if the system wide storage.conf file
/usr/share/containers/storage.conf exists.
Since distros ship this, we need to allow Podman to check if the default is the System default and therefore do not warn.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com