overlay: fix call to clone on s390x #1418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the two arguments to clone are swapped on s390x. This patch fixes the call when running on s390x. Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2108887 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
LGTM |
This was referenced Nov 4, 2022
This was referenced Dec 2, 2022
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/buildah
that referenced
this pull request
Jan 5, 2023
Bump the c/storage to v1.43.1 so this v1.28 branch will have access to the fix for https://bugzilla.redhat.com/show_bug.cgi?id=2140087 - SIGSEGV: segmentation violation on s390x. This was originally fixed with containers/storage#1418 and is being vendored here now as the fix is in the v1.27 branch already. [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/buildah
that referenced
this pull request
Jan 5, 2023
Bump the c/storage to v1.43.1 so this v1.28 branch will have access to the fix for https://bugzilla.redhat.com/show_bug.cgi?id=2140087 - SIGSEGV: segmentation violation on s390x. This was originally fixed with containers/storage#1418 and is being vendored here now as the fix is in the v1.27 branch already. Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2140087 [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the two arguments to clone are swapped on s390x. This patch fixes the call when running on s390x.
Closes: https://bugzilla.redhat.com/show_bug.cgi?id=2108887
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com