Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DriverTestSetQuota: Put() after Get() #1548

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

nalind
Copy link
Member

@nalind nalind commented Mar 31, 2023

Convention for tests is that they Put() any layers they Get(). Fix this omission in DriverTestSetQuota() and change the layer name from "zfsTest" to "quotaTest", because we have quota support on more than just zfs.

Convention for tests is that they Put() any layers they Get().  Fix this
omission in DriverTestSetQuota() and change the layer name from
"zfsTest" to "quotaTest", because we have quota support on more than
just zfs.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Apr 1, 2023

Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@giuseppe giuseppe merged commit 0f3b742 into containers:main Apr 3, 2023
@nalind nalind deleted the graphtest-quota-put branch April 3, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants