pkg/rm: attempt os.RemoveAll() first #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kolyshkin PTAL |
|
LGTM |
giuseppe
force-pushed
the
ensure-rm-all-no-rec-umount
branch
from
c57dff9
to
61c8d60
Compare
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
ensure-rm-all-no-rec-umount
branch
from
61c8d60
to
606b958
Compare
|
rebased on top of #1585 |
the mount.RecursiveUnmount() call can be expensive, since it needs to parse the mount table to reconstruct the mount tree. Attempt the simple case first, and do the more expensive removal only if necessary. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
ensure-rm-all-no-rec-umount
branch
from
606b958
to
6b7e512
Compare
kolyshkin
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the mount.RecursiveUnmount() call can be expensive, since it needs to parse the mount table to reconstruct the mount tree.
Attempt the simple case first, and do the more expensive removal only if necessary.