quota: unlink tmp file before creating it #1631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edsantiago
reviewed
Jun 6, 2023
Before creating the tmp file, we unlink it first to avoid an EEXIST error. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
LGTM |
1 similar comment
|
LGTM |
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Sep 13, 2023
As the c/storage release-1.45 branch can't run tests at the moment, do a WIP vendor in Podman v4.4.1-rhel. This backport a fix for c/storage for unlink functionaliy from containers/storage#1631 [NO NEW TESTS NEEDED] Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Sep 14, 2023
This backport a fix for c/storage for unlink functionaliy from containers/storage#1631 This was a WIP, but has been updated and is ready to merge, assuming happy tests. [NO NEW TESTS NEEDED] Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
TomSweeneyRedHat
added a commit
to TomSweeneyRedHat/podman
that referenced
this pull request
Sep 14, 2023
This backport a fix for c/storage for unlink functionaliy from containers/storage#1631 This was a WIP, but has been updated and is ready to merge, assuming happy tests. [NO NEW TESTS NEEDED] Signed-off-by: TomSweeneyRedHat <tsweeney@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before creating the tmp file, we unlink it first to avoid an EEXIST error.