types/options: check prior drivers using readdir #1637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luap99
reviewed
Jun 12, 2023
types/options.go
Outdated
| if strings.HasSuffix(entry.Name(), "-images") { | ||
| res := strings.Split(entry.Name(), "-images") | ||
| if len(res) > 0 { | ||
| opts.GraphDriverName = res[0] |
types/options.go
Outdated
| if err == nil { | ||
| for _, entry := range dirEntries { | ||
| if strings.HasSuffix(entry.Name(), "-images") { | ||
| res := strings.Split(entry.Name(), "-images") |
There was a problem hiding this comment.
I think using TrimSuffix() is better than using Split().
Fetch prior drivers if any using `ReadDir` and looking for traces of `%s-images` dirs if present already on the system where `%s` is the prior driver. Signed-off-by: Aditya R <arajan@redhat.com>
flouthoc
force-pushed
the
use-readdir-prior
branch
from
9bc084c
to
e31225e
Compare
|
LGTM |
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Jun 13, 2023
This reverts commit ebf7474. With the c/storage change[1] we no longer need this workaround. [1] containers/storage#1637
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Jun 13, 2023
This reverts commit ebf7474. With the c/storage change[1] we no longer need this workaround. [1] containers/storage#1637 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Jun 13, 2023
This reverts commit ebf7474. With the c/storage change[1] we no longer need this workaround. [1] containers/storage#1637 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
cgiradkar
pushed a commit
to cgiradkar/podman
that referenced
this pull request
Jul 12, 2023
This reverts commit ebf7474. With the c/storage change[1] we no longer need this workaround. [1] containers/storage#1637 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
cgiradkar
pushed a commit
to cgiradkar/podman
that referenced
this pull request
Jul 13, 2023
This reverts commit ebf7474. With the c/storage change[1] we no longer need this workaround. [1] containers/storage#1637 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
cgiradkar
pushed a commit
to cgiradkar/podman
that referenced
this pull request
Jul 17, 2023
This reverts commit ebf7474. With the c/storage change[1] we no longer need this workaround. [1] containers/storage#1637 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
cgiradkar
pushed a commit
to cgiradkar/podman
that referenced
this pull request
Jul 17, 2023
This reverts commit ebf7474. With the c/storage change[1] we no longer need this workaround. [1] containers/storage#1637 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fetch prior drivers if any using
ReadDirand looking for traces of%s-imagesdirs if present already on the system where%sis the prior driver.Closes: #1618 (comment)