Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options,rootless: honor imagestore from config file #1645

Merged
merged 1 commit into from
Jun 16, 2023

Conversation

flouthoc
Copy link
Collaborator

Honor imagestore option from config file for rootless setups.

Fixes issues in: containers/podman#18224

Honor `imagestore` option from config file for rootless setups.

Fixes issues in: containers/podman#18224

Signed-off-by: Aditya R <arajan@redhat.com>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Any chance for a regression test, or will you add one to Podman?

@flouthoc
Copy link
Collaborator Author

flouthoc commented Jun 16, 2023

@vrothberg Yes there is a test already added to podman, containers/podman#18224 CI blocked because of this.

@vrothberg vrothberg merged commit cc0d208 into containers:main Jun 16, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants