Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

overlay: Diffsize: avoid naive diff #1688

Merged
merged 1 commit into from
Aug 14, 2023

Commits on Aug 14, 2023

  1. overlay: Diffsize: avoid naive diff

    Computing the diff size for the rootful overlay storage driver used the
    naive diff.  The reasoning was that we have made use of rootful copy-up.
    The downside is a mind-blowing performance penalty in comparison to the
    rootless case.
    
    Hence, drop the naive diff and only compute the size of the directory
    which is absolutely sufficient for the motivating use case of
    podman-system-df.  This drops the execution of system-df from 19.3s to
    0.11s listing 5 containers and 1 image.
    
    Fixes: github.com/containers/podman/issues/19467
    Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
    Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
    vrothberg committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    7618ac8 View commit details
    Browse the repository at this point in the history