Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlay: select additional image store path when using image store #1732

Merged
merged 1 commit into from Oct 18, 2023
Merged

overlay: select additional image store path when using image store #1732

merged 1 commit into from Oct 18, 2023

Conversation

sstosh
Copy link
Contributor

@sstosh sstosh commented Oct 18, 2023

If parentBase path is additional image store, select the image contained in parentBase.
Otherwise, the overlay storage driver may select another image store that does not contain
the desired image, causing a no suche file or directory error.

Fixes: containers/podman#19748

@sstosh
overlay: select additional image store path when using image store
a5c8550 
If parentBase path is additional image store, select the image contained in parentBase.
Otherwise, the overlay storage driver may select another image store that does not contain
the desired image, causing a "no suche file or directory" error.

Fixes: containers/podman#19748

Signed-off-by: Toshiki Sonoda <sonoda.toshiki@fujitsu.com>
flouthoc
flouthoc approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks @sstosh

@flouthoc
Copy link
Collaborator

@giuseppe PTAL

giuseppe
giuseppe approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

would it be possible to get a test for this case?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flouthoc, giuseppe, sstosh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rhatdan
Copy link
Member

rhatdan commented Oct 18, 2023

LGTM

@flouthoc
Copy link
Collaborator

@sstosh Could you open a PR against podman with vendor of this PR uncommenting podman pull and run on split imagestore the skip for the test with overlay it will test this PR as well.

@edsantiago
Copy link
Collaborator

Clarification: there is absolutely no point to opening a podman PR, because podman CI e2e tests do not test overlay. Please don't bother. I'm testing it now in #17831.

@edsantiago
Copy link
Collaborator

New code passes under overlay:

  • confirm that test truly passes and is not skipped
    • hover mouse over [options] to confirm that overlay is used
  • confirm that all other tests pass, both overlay and vfs (this is actually a small miracle: no podman cp flakes!)

LGTM. Thank you @sstosh!

@rhatdan rhatdan merged commit 8254d6f into containers:main Oct 18, 2023
18 of 19 checks passed
@sstosh sstosh deleted the fix-image-store branch October 18, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

@flouthoc flouthoc flouthoc approved these changes

Assignees
No one assigned
Labels
approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

e2e tests: split imagestore test failed when setting STORAGE_FS=overlay
5 participants
@sstosh @flouthoc @rhatdan @edsantiago @giuseppe