graphtest: skip tests on insufficient permissions #1780
Conversation
mvo5
force-pushed
the
skip-driver-tests-on-eperm
branch
from
242fa58
to
5024d4f
Compare
|
You have to sign your commits git commit -a --amend -s |
When a graphdriver cannot be tested because of e.g. `ErrIncompatibleFS` it is skipped. However this seems not to be the case for permission error and when running the tests as user they fail with: ``` chown: ... operation not permited ``` This commit changes the test code to account for this as well and skip when there are insufficient permissions. Signed-off-by: Michael Vogt <michael.vogt@gmail.com>
mvo5
force-pushed
the
skip-driver-tests-on-eperm
branch
from
5024d4f
to
40f19b7
Compare
|
@TomSweeneyRedHat Hey, thanks for the reminder and sorry that I did not reply earlier. I did the force push with the |
|
@mvo5 Ooops, my bad, I scanned the error too quickly last night and missed your update. The PR just needed to be updated, which I've just started, and then reviewed. LGTM @edsantiago PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mvo5, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/unhold |
Just a quick drive-by while working on #1779 - feel free to close if you disagree or feel it's the wrong approach (sorry, I'm new to this codebase) but I wanted to share it for your consideration :)
When a graphdriver cannot be tested because of e.g.
ErrIncompatibleFSit is skipped. However this seems not to be the case for permission error and when running the tests as user they fail with:This commit changes the test code to account for this as well and skip when there are insufficient permissions.