Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homedir: use containers/storage on Windows #1812

Merged

Conversation

giuseppe
Copy link
Member

@giuseppe giuseppe commented Jan 29, 2024

follow-up to #1810

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe
Copy link
Member Author

@ashley-cui PTAL

@nalind
Copy link
Member

nalind commented Jan 29, 2024

/lgtm
/hold

@rhatdan
Copy link
Member

rhatdan commented Jan 29, 2024

LGTM

@openshift-ci openshift-ci bot added the lgtm label Jan 29, 2024
Copy link
Contributor

openshift-ci bot commented Jan 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: giuseppe, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ashley-cui
Copy link
Member

/hold cancel

@openshift-merge-bot openshift-merge-bot bot merged commit 7a525ce into containers:main Jan 29, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants