chunked: improve function to merge chunks #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
improve-chunked-merge-heuristic
branch
from
631f5e8
to
5a50f39
Compare
|
LGTM |
|
@mtrmac @nalind @saschagrunert PTAL |
saschagrunert
approved these changes
Mar 1, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
mtrmac
reviewed
Mar 1, 2024
giuseppe
force-pushed
the
improve-chunked-merge-heuristic
branch
from
5a50f39
to
70ce1c0
Compare
improve the function that combines neighbor chunks. Instead of using the number of parts, which also includes local files, use only the number of chunks that must be retrieved from the network. In addition, introduce a threshold limit to merge chunks so that we further reduce the number of requested ranges. Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
force-pushed
the
improve-chunked-merge-heuristic
branch
from
70ce1c0
to
43b836e
Compare
openshift-merge-bot
bot
merged commit 7cd5d22
into
containers:main
6 of 18 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve the function that combines neighbor chunks. Instead of using the number of parts, which also includes local files, use only the number of chunks that must be retrieved from the network.
In addition, introduce a threshold limit to merge chunks so that we further reduce the number of requested ranges.