User are reporting potential issues with using overlay2 #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
types/options.go
Outdated
| @@ -190,6 +190,10 @@ func getRootlessStorageOpts(rootlessUID int, systemOpts StoreOptions) (StoreOpti | |||
| if driver := os.Getenv("STORAGE_DRIVER"); driver != "" { | |||
| opts.GraphDriverName = driver | |||
| } | |||
| // override users selection of 'overlay2' with 'overlay' | |||
| if opts.GraphDriverName == "overlay2" { | |||
There was a problem hiding this comment.
lint is barfing, it wants a constant for "overlay2"
rhatdan
force-pushed
the
default
branch
2 times, most recently
from
dc234da
to
09a2e99
Compare
|
@rhatdan looks like you need a rebase |
types/options.go
Outdated
| @@ -190,6 +194,10 @@ func getRootlessStorageOpts(rootlessUID int, systemOpts StoreOptions) (StoreOpti | |||
| if driver := os.Getenv("STORAGE_DRIVER"); driver != "" { | |||
| opts.GraphDriverName = driver | |||
| } | |||
| // override users selection of 'overlay2' with 'overlay' | |||
There was a problem hiding this comment.
Might want to leave behind a comment as to why the override is happening.
|
This is a Potentially breaking change, and should be held off until 4.0 of Podman. |
rhatdan
changed the title
rhatdan
force-pushed
the
default
branch
5 times, most recently
from
63003fd
to
fd652a2
Compare
We should just switch to overlay right away rather then handling the driver code lower in the stack. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
rhatdan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should just switch to overlay right away rather then
handling the driver code lower in the stack.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com