fix: use FQDN with `toolbox` prefix #1086

akdev1l · 2022-08-17T01:50:56Z

Issue: #969

Setting the hostname to toolbox causes timeouts whenever anything tries
to resolve the name of the machine - for example sudo does this.

This change makes it so the FQDN is set to
${container_name}.${hostname} as recommended in the linked issue.

After this change commands can properly resolve the local FQDN.

I removed the symlink to /run/host/etc/hosts because podman already copies that information in and then we can use --add-host to add a mapping to localhost for the container - this way calling ping $(hostname) does what is expected.

Pending PRs:

Allow toolbox containers to be created with a custom hostname #1007 - this adds a new flag to allow setting the hostname of the toolbox, I think this should just follow the container-name.hostname convention otherwise it seems confusing
https://github.com/containers/toolbox/pull/771/files - similar but sets the hostname of the container to be equal to the container name - the name is still unresolvable however.
https://github.com/containers/toolbox/pull/383/files - same as above but tries to sanitize the container name
https://github.com/containers/toolbox/pull/573/files - Obsolete, PR against bash toolbox

None of these PRs address my issue with delays due to unresolvable hostnames. So this one tries to do that.

Sample Output

[akdev@canzuk toolbox]$ ./build/src/toolbox create -i docker.io/akdev1l/ubuntu-toolbox:22.04 test1
Created container: test1
Enter with: toolbox enter test1
[akdev@canzuk toolbox]$ ./build/src/toolbox enter test1
⬢[akdev@test1 toolbox]$ hostname
test1.canzuk.hq.akdev.xyz
⬢[akdev@test1 toolbox]$ cat /etc/hosts
127.0.0.1	test1.canzuk.hq.akdev.xyz
127.0.0.1	localhost localhost.localdomain localhost4 localhost4.localdomain4 toolbox
::1	localhost localhost.localdomain localhost6 localhost6.localdomain6
10.0.1.100	host.containers.internal

softwarefactory-project-zuul · 2022-08-17T02:10:37Z

Build succeeded.

✔️ unit-test SUCCESS in 6m 54s
✔️ system-test-fedora-rawhide SUCCESS in 16m 52s
✔️ system-test-fedora-36 SUCCESS in 9m 51s
✔️ system-test-fedora-35 SUCCESS in 10m 05s

akdev1l · 2022-08-17T03:47:06Z

this seems to trigger a minor bug, when exiting the toolbox if I pressed ctrl+c at the prompt then toolbox falsely prints out an empty Error: message

I'll have to dig into that

softwarefactory-project-zuul · 2022-08-17T22:38:56Z

Build succeeded.

✔️ unit-test SUCCESS in 6m 57s
✔️ system-test-fedora-rawhide SUCCESS in 11m 04s
✔️ system-test-fedora-36 SUCCESS in 9m 57s
✔️ system-test-fedora-35 SUCCESS in 10m 10s

softwarefactory-project-zuul · 2022-08-18T01:03:59Z

Build failed.

❌ unit-test NODE_FAILURE in 0s
✔️ system-test-fedora-rawhide SUCCESS in 13m 16s
✔️ system-test-fedora-36 SUCCESS in 13m 16s
✔️ system-test-fedora-35 SUCCESS in 13m 51s

akdev1l · 2022-08-19T00:44:17Z

sorry for the noise the bug I hit seems to be because toolbox exits with return code 130 (SIGTERM) whenever ctrl+c is pressed - seriously wondering how my changes triggered this

akdev1l · 2022-08-19T02:10:01Z

capsh --caps= -- -c exec "$@" /bin/sh /bin/bash -l

why is so convoluted ... it would seems this is equivalent

capsh --caps= -- -c 'exec /bin/bash -l'

mm from further experimentation it seems that bash just does this and toolbox should just ignore the 130 error code

toolbox without modification does this:

[akdev@canzuk toolbox]$ toolbox enter test10
⬢[akdev@test10 toolbox]$ ^C
⬢[akdev@test10 toolbox]$ ^C
⬢[akdev@test10 toolbox]$ ^C
⬢[akdev@test10 toolbox]$
logout
[akdev@canzuk toolbox]$ echo $?
0
[akdev@canzuk toolbox]$ bash
[akdev@canzuk toolbox]$ ^C
[akdev@canzuk toolbox]$ ^C
[akdev@canzuk toolbox]$
exit
[akdev@canzuk toolbox]$ echo $?
130

imo this should keep the error code of the last command execute so it should be 130 at the end to match the behaviour of bash - we could probably simplify that capsh shenanigans, looks like there's at least an unnecessary fork there

softwarefactory-project-zuul · 2022-08-19T02:27:05Z

Build failed.

❌ unit-test FAILURE in 7m 15s
❌ system-test-fedora-rawhide FAILURE in 16m 10s
❌ system-test-fedora-36 FAILURE in 10m 29s
❌ system-test-fedora-35 FAILURE in 10m 34s

softwarefactory-project-zuul · 2022-08-19T03:26:25Z

Build failed.

✔️ unit-test SUCCESS in 7m 07s
❌ system-test-fedora-rawhide FAILURE in 15m 36s
❌ system-test-fedora-36 FAILURE in 10m 27s
❌ system-test-fedora-35 FAILURE in 10m 41s

softwarefactory-project-zuul · 2022-08-19T05:53:08Z

Build failed.

✔️ unit-test SUCCESS in 7m 03s
❌ system-test-fedora-rawhide FAILURE in 15m 52s
❌ system-test-fedora-36 FAILURE in 10m 13s
❌ system-test-fedora-35 FAILURE in 10m 30s

softwarefactory-project-zuul · 2022-08-19T05:56:18Z

Build failed.

✔️ unit-test SUCCESS in 7m 10s
❌ system-test-fedora-rawhide FAILURE in 16m 00s
❌ system-test-fedora-36 FAILURE in 10m 19s
❌ system-test-fedora-35 FAILURE in 10m 54s

akdev1l · 2022-08-25T01:57:00Z

I have continued development of toolbox on my own as I'm not really having this merged on a reasonable time frame.

my fork is at: https://github.com/akdev1l/toolbox/tree/akdev

I have fixed some long standing issues and added some features (particularly I have enabled a static build and containerized toolbox itself, resolved the DNS issues and added basic export support) - feel free to ping me if there's any interest on that.

Otherwise I will leave this PR to die - feel free to close.

debarshiray

It will be good if the commit message had some explanation around exit code 130 and SIGTERM. Particularly the user facing behaviour.

debarshiray · 2022-11-17T20:26:26Z

src/cmd/run.go

@@ -477,10 +479,10 @@ func constructExecArgs(container string,

 	execArgs = append(execArgs, []string{
 		container,
-		"capsh", "--caps=", "--", "-c", "exec \"$@\"", "/bin/sh",
+		"capsh", "--caps=", "--", "-c",


This doesn't seem to have anything to do with what the commit message describes. :)

src/cmd/run.go

debarshiray · 2022-11-17T21:04:36Z

sorry for the noise the bug I hit seems to be because toolbox
exits with return code 130 (SIGTERM) whenever ctrl+c is
pressed - seriously wondering how my changes triggered this

I don't think your changes introduced that. :)

A few months ago, Toolbx started propagating the exit code of the command, which triggered this. You wouldn't have encountered this behaviour before that.

From the bash(1) manual:

When a command terminates on a fatal signal N,
bash uses the value of 128+N as the exit status.

Ctrl+c is SIGINT (not SIGTERM) and it's numerical value is 2:

$ kill -L
 1) SIGHUP	 2) SIGINT ...

Hence, 130 (= 128 + 2) as the exit code.

debarshiray

Thanks for working on this, @akdev1l ; and my apologies for the delay.

images/fedora/f32/README.md

src/cmd/create.go

debarshiray · 2022-11-17T21:57:29Z

Setting the hostname to toolbox causes timeouts whenever
anything tries to resolve the name of the machine - for example
sudo does this.

I am curious. I have never experienced delays when using sudo(8) inside a Toolbx container, but maybe you are doing something that I never do. Could you please describe this in a bit more detail?

debarshiray · 2022-11-18T16:14:41Z

I have enabled a static build

The way things stand today, we are unlikely to build statically or disable CGO. See: #832

Of course, this may change if our realities change or if new information comes to light.

akdev1l · 2022-11-26T18:27:46Z

@debarshiray hi! thanks for your comments - I'll clean this up and just deal with the fqdn change

you gave me some historical background on toolbx and I appreciate that.

I am curious. I have never experienced delays when using sudo(8) inside a Toolbx container, but maybe you are doing something that I never do. Could you please describe this in a bit more detail?

this happened to me because I build/distribute my own toolbx images (https://github.com/akdev1l/toolbox-images) - there is a requirement that isn't specified in the documentation which is having nss-myhostname installed and enabled in /etc/nsswitch.conf in the toolbox image. Without that sudo tries to resolve the container hostname and fails. (using the fqdn as originally intended in this PR solves this issue too as the name is resolvable, hence that was original drive for this change)

debarshiray · 2022-11-29T01:14:48Z

this happened to me because I build/distribute my own toolbx
images (https://github.com/akdev1l/toolbox-images) - there is
a requirement that isn't specified in the documentation which
is having nss-myhostname installed and enabled in
/etc/nsswitch.conf in the toolbox image. Without that sudo
tries to resolve the container hostname and fails. (using the
fqdn as originally intended in this PR solves this issue too as the
name is resolvable, hence that was original drive for this change)

nod

@HarryMichal explained that to me later in real life. My apologies, I forgot to mention that here.

akdev1l · 2022-12-05T22:23:33Z

@debarshiray minimal cleaned this up, this should be the minimal change required for a proper FQDN - looks like it passes the tests

I still think we should change the prefix from "toolbox" to the name of the toolbox, bash prompts seem to show the first component of the FQDN (with this change there won't be any user visible prompt changes as we have hardcoded it the first component to toolbox for now)

[akdev@toronto toolbox]$ echo $PS1
[\u@\h \W]\$

so this would solve the issue of distinguishing the containers very elegantly imo (no changes required on the images, no big changes required on toolbox, no custom scripts nor custom prompts for bash or other shells)

softwarefactory-project-zuul · 2022-12-05T22:43:46Z

Build succeeded.

✔️ unit-test SUCCESS in 8m 14s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 8m 26s
✔️ system-test-fedora-rawhide SUCCESS in 32m 01s
✔️ system-test-fedora-36 SUCCESS in 11m 08s
✔️ system-test-fedora-35 SUCCESS in 12m 08s

Signed-off-by: Alex Diaz <alex@akdev.xyz>

softwarefactory-project-zuul · 2022-12-05T23:17:59Z

Build succeeded.

✔️ unit-test SUCCESS in 8m 14s
✔️ unit-test-migration-path-for-coreos-toolbox SUCCESS in 8m 14s
✔️ system-test-fedora-rawhide SUCCESS in 31m 57s
✔️ system-test-fedora-36 SUCCESS in 11m 00s
✔️ system-test-fedora-35 SUCCESS in 11m 52s

jkemp814 · 2023-02-08T05:44:04Z

#98 (comment)

jnohlgard · 2023-04-13T07:59:59Z

@debarshiray Does this PR need anything else before merging?
This PR fixes a quite annoying problem #1059 when using GUI apps inside toolbox when running KDE on the host. Having the host's host name as the domain for the toolbox container's host name fixes that issue.

nievesmontero · 2023-07-05T10:23:32Z

Hey @akdev1l, sorry for the delay on this PR. I am reviewing everything to merge it as soon as possible.

I just wanted to ask a quick question. At the beginnning of the issue, in the initial explanation, you say that the expected container hostname is the following ${container_name}.${hostname}. However, after reviewing the code I realised that it is actually toolbox.${hostname}, am I right?

runiq · 2023-07-05T10:27:15Z

At the beginnning of the issue, in the initial explanation, you say that the expected container hostname is the following ${container_name}.${hostname}. However, after reviewing the code I realised that it is actually toolbox.${hostname}, am I right?

As someone who uses multiple toolboxes (one for regular development work, and a "grab-bag" one for other stuff), I would prefer the container name. (But it's not a big deal, honestly, since I can always change the prompt from within the toolbox itself.)

nievesmontero · 2023-07-05T10:33:27Z

I also wanted to reproduce those timeouts you were talking about. Could you please let me know which commands led you to those timeouts so that I can reproduce them on my machine?

jnohlgard · 2023-07-10T07:22:26Z

I also wanted to reproduce those timeouts you were talking about. Could you please let me know which commands led you to those timeouts so that I can reproduce them on my machine?

Personally I encountered them mostly when using Jetbrains IDEs, e.g. IntelliJ, CLion, from within toolbox on a Fedora Kinoite (KDE plasma) system, but it should be possible to reproduce with other GUI apps on a KDE system because the problems seem to be with kwin trying to do some DNS resolution in relation to putting the host name in the title bar of the windows ("xterm <@toolbox>". Sorry I don't have any more exact recipe for this though.

juhp · 2023-08-25T08:50:52Z

+1 for using the container name for the hostname.
Distrobox already does this I believe.
With multiple toolboxes it makes much more sense.

runiq · 2023-10-05T18:30:44Z

I just realized something: With the Foot terminal (and others), I can emit OSC 7 on directory change to have new terminals spawn in that directory. However, if you look at the linked code snippet:

printf \e\]7\;file://%s%s\e\\ $hostname (string escape --style=url $PWD)

You can see that this depends on the correct hostname (so that it doesn't erroneously catch directory changes over SSH connections, for example).

So, the toolbox not having the host's hostname breaks at least that bit of functionality.

akdev1l force-pushed the main branch from 92fad86 to 1b4d28c Compare August 17, 2022 01:52

akdev1l force-pushed the main branch from 1272a2a to 1b4d28c Compare August 18, 2022 00:38

akdev1l force-pushed the main branch from 99c5f3b to 1e9f356 Compare August 19, 2022 03:09

akdev1l force-pushed the main branch from 031de17 to 1e9f356 Compare August 19, 2022 05:38

akdev1l mentioned this pull request Aug 31, 2022

sudo doesn't work on Ubuntu toolbox akdev1l/toolbox-images#4

Closed

debarshiray mentioned this pull request Oct 14, 2022

Allow toolbox containers to be created with a custom hostname #1134

Closed

debarshiray requested changes Nov 17, 2022

View reviewed changes

images/fedora/f32/README.md Outdated Show resolved Hide resolved

src/cmd/create.go Outdated Show resolved Hide resolved

debarshiray mentioned this pull request Nov 17, 2022

Use container name as container hostname #383

Closed

akdev1l force-pushed the main branch from 1e9f356 to fa6ce2e Compare December 5, 2022 22:10

akdev1l changed the title ~~fix: don't use toolbox as constant for FQDN~~ fix: use FQDN with toolbox prefix Dec 5, 2022

fix: add proper FQDN to toolbox containers

b89e55f

Signed-off-by: Alex Diaz <alex@akdev.xyz>

akdev1l force-pushed the main branch from fa6ce2e to b89e55f Compare December 5, 2022 22:45

akdev1l requested a review from debarshiray December 5, 2022 22:57

akdev1l mentioned this pull request Jan 30, 2023

Set hostname to toolbox.{host_hostname} #1215

Open

lrittel mentioned this pull request Mar 19, 2023

Offer a better way to visually distinguish between containers #98

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: use FQDN with `toolbox` prefix #1086

fix: use FQDN with `toolbox` prefix #1086

akdev1l commented Aug 17, 2022 •

edited

softwarefactory-project-zuul bot commented Aug 17, 2022

akdev1l commented Aug 17, 2022

softwarefactory-project-zuul bot commented Aug 17, 2022

softwarefactory-project-zuul bot commented Aug 18, 2022

akdev1l commented Aug 19, 2022

akdev1l commented Aug 19, 2022

softwarefactory-project-zuul bot commented Aug 19, 2022

softwarefactory-project-zuul bot commented Aug 19, 2022

softwarefactory-project-zuul bot commented Aug 19, 2022

softwarefactory-project-zuul bot commented Aug 19, 2022

akdev1l commented Aug 25, 2022

debarshiray left a comment

debarshiray Nov 17, 2022

debarshiray commented Nov 17, 2022 •

edited

debarshiray left a comment

debarshiray commented Nov 17, 2022

debarshiray commented Nov 18, 2022

akdev1l commented Nov 26, 2022

debarshiray commented Nov 29, 2022

akdev1l commented Dec 5, 2022

softwarefactory-project-zuul bot commented Dec 5, 2022

softwarefactory-project-zuul bot commented Dec 5, 2022

jkemp814 commented Feb 8, 2023

jnohlgard commented Apr 13, 2023

nievesmontero commented Jul 5, 2023 •

edited

runiq commented Jul 5, 2023

nievesmontero commented Jul 5, 2023

jnohlgard commented Jul 10, 2023

juhp commented Aug 25, 2023

runiq commented Oct 5, 2023

fix: use FQDN with toolbox prefix #1086

Are you sure you want to change the base?

fix: use FQDN with toolbox prefix #1086

Conversation

akdev1l commented Aug 17, 2022 • edited

Issue: #969

Sample Output

softwarefactory-project-zuul bot commented Aug 17, 2022

akdev1l commented Aug 17, 2022

softwarefactory-project-zuul bot commented Aug 17, 2022

softwarefactory-project-zuul bot commented Aug 18, 2022

akdev1l commented Aug 19, 2022

akdev1l commented Aug 19, 2022

softwarefactory-project-zuul bot commented Aug 19, 2022

softwarefactory-project-zuul bot commented Aug 19, 2022

softwarefactory-project-zuul bot commented Aug 19, 2022

softwarefactory-project-zuul bot commented Aug 19, 2022

akdev1l commented Aug 25, 2022

debarshiray left a comment

Choose a reason for hiding this comment

debarshiray Nov 17, 2022

Choose a reason for hiding this comment

debarshiray commented Nov 17, 2022 • edited

debarshiray left a comment

Choose a reason for hiding this comment

debarshiray commented Nov 17, 2022

debarshiray commented Nov 18, 2022

akdev1l commented Nov 26, 2022

debarshiray commented Nov 29, 2022

akdev1l commented Dec 5, 2022

softwarefactory-project-zuul bot commented Dec 5, 2022

softwarefactory-project-zuul bot commented Dec 5, 2022

jkemp814 commented Feb 8, 2023

jnohlgard commented Apr 13, 2023

nievesmontero commented Jul 5, 2023 • edited

runiq commented Jul 5, 2023

nievesmontero commented Jul 5, 2023

jnohlgard commented Jul 10, 2023

juhp commented Aug 25, 2023

runiq commented Oct 5, 2023

fix: use FQDN with `toolbox` prefix #1086

fix: use FQDN with `toolbox` prefix #1086

akdev1l commented Aug 17, 2022 •

edited

debarshiray commented Nov 17, 2022 •

edited

nievesmontero commented Jul 5, 2023 •

edited