cmd/initContainer: Don't rely on user D-Bus to track time zone configuration #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failed.
|
debarshiray
changed the title
|
Build failed.
|
debarshiray
force-pushed
the
wip/rishi/monitor-config-files
branch
from
921f50c
to
2f3bab5
Compare
|
Build failed.
|
|
Build failed.
|
debarshiray
force-pushed
the
wip/rishi/monitor-config-files
branch
from
b4d1bd8
to
ed1b46f
Compare
|
Build failed.
|
debarshiray
force-pushed
the
wip/rishi/monitor-config-files
branch
from
ed1b46f
to
e642ae7
Compare
|
Build failed.
|
debarshiray
force-pushed
the
wip/rishi/monitor-config-files
branch
from
e642ae7
to
c0eb08a
Compare
|
Build failed.
|
debarshiray
force-pushed
the
wip/rishi/monitor-config-files
branch
from
c0eb08a
to
5490d07
Compare
|
Build failed.
|
This is one more step towards enabling toolbox(1) to be run as root. When invoked as 'sudo toolbox ...' there's no user or session D-Bus instance available for the root user, which prevents the use of D-Bus services like org.freedesktop.Flatpak.SessionHelper. containers#267
This is one more step towards enabling toolbox(1) to be run as root. When invoked as 'sudo toolbox ...' there's no user or session D-Bus instance available for the root user, which prevents the use of D-Bus services like org.freedesktop.Flatpak.SessionHelper. The code is forgiving to runtime errors when reacting to file system events because it's not worth abruptly terminating the entry point because of what might be a passing error. However, it's a lot stricter when initially configuring the container because the failure mode isn't as surprising for the user and it's worth starting from a valid state. containers#267
It's no longer used to keep /etc/localtime and /etc/timezone synchronized with the host. containers#267
... that were created to have a bind mount at /run/host/monitor. Newly created containers no longer need org.freedesktop.Flatpak.SessionHelper and hence the D-Bus service doesn't need to be started for them. containers#267
debarshiray
force-pushed
the
wip/rishi/monitor-config-files
branch
from
5490d07
to
82c32be
Compare
|
Build failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one more step towards enabling toolbox(1) to be run as root.
When invoked as 'sudo toolbox ...' there's no user or session D-Bus
instance available for the root user, which prevents the use of D-Bus
services like o.fd.Flatpak.SessionHelper.
#267