Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/create: Mention that private images require 'podman login' #852

Conversation

debarshiray
Copy link
Member

It's not possible to programmatically detect when an image requires
logging into the registry [1]. Therefore, instead of trying to handle
'podman pull' failures due to lack of authorization, just mention that
private images require 'podman login' and that further details of the
failure can be found by using the --verbose option.

[1] containers/podman#10858

#754

debarshiray added a commit to debarshiray/toolbox that referenced this pull request Jul 23, 2021
It's not possible to programmatically detect when an image requires
logging into the registry [1]. Therefore, instead of trying to handle
'podman pull' failures due to lack of authorization, just mention that
private images require 'podman login' and that further details of the
failure can be found by using the --verbose option.

[1] containers/podman#10858

containers#754
containers#852
@debarshiray debarshiray force-pushed the wip/rishi/mention-need-to-authenticate branch from 008cff0 to 6672aa7 Compare July 23, 2021 01:47
It's not possible to programmatically detect when an image requires
logging into the registry [1]. Therefore, instead of trying to handle
'podman pull' failures due to lack of authorization, just mention that
private images require 'podman login' and that further details of the
failure can be found by using the --verbose option.

[1] containers/podman#10858

containers#754
containers#852
@debarshiray debarshiray force-pushed the wip/rishi/mention-need-to-authenticate branch from 6672aa7 to 660b697 Compare July 23, 2021 02:02
@debarshiray debarshiray merged commit 660b697 into containers:main Jul 23, 2021
@debarshiray debarshiray deleted the wip/rishi/mention-need-to-authenticate branch July 23, 2021 02:03
@HarryMichal HarryMichal added 6. Minor Change Should not cause breakage 3. Enhancement Improvement to an existing feature 2. CLI Issue is related to the command line interface 2. Host Realm The issue is related to what happens on the host machine where Toolbox is executed 7. Needs tests The work needs new test cases added labels Jul 23, 2021
HarryMichal added a commit to HarryMichal/toolbox that referenced this pull request Jul 28, 2021
HarryMichal added a commit to HarryMichal/toolbox that referenced this pull request Jul 28, 2021
HarryMichal added a commit to HarryMichal/toolbox that referenced this pull request Jul 28, 2021
HarryMichal added a commit that referenced this pull request Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. CLI Issue is related to the command line interface 2. Host Realm The issue is related to what happens on the host machine where Toolbox is executed 3. Enhancement Improvement to an existing feature 6. Minor Change Should not cause breakage 7. Needs tests The work needs new test cases added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants