-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lack of check that check presence of sections #105
Comments
Thanks for the suggestion. I'll definitely add some sort of checking. I'm just wondering if there was any reason to use decorator factory instead of a simple decorator that would catch KeyError. e.g.
Also, returning |
Fixes: containers#105 Inspired by: WellIDKRealy@0c56d98 Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
Fixes: containers#105, containers#103 Inspired by: WellIDKRealy@0c56d98 Signed-off-by: Vit Mojzis <vmojzis@redhat.com>
I used decorator factory because if there was any error unrelated to sections not existing and of the same type as error caused by nonexistence of them it still would be caught. Anyways thanks for adding those checks. |
Describe the bug
If some sections are not present for example Mounts udcia will crash with Key error as cause etc
Even if i did something completely wrong it should be indicated Key Error error does not indicate it well IMO
To Reproduce
Make any container that does not have Mounts. NetworkSettings or Host config
run idcia on it
Example steps
podman pod create --name a
podman run -it --rm --pod a fedora /bin/bash
podman inspect k8s.gcr.io/pause:3.5
Expected behavior
Policy for mounts shoudl't be added if mounts are not present etc
Proposed Fix
https://github.com/WellIDKRealy/udica
i didn't test it extensively so i have no idea if i broke something
The text was updated successfully, but these errors were encountered: