Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update oci-spec to v0.6.7 #2847

Merged
merged 1 commit into from
Jul 14, 2024

Conversation

Mossaka
Copy link
Contributor

@Mossaka Mossaka commented Jul 9, 2024

there is a breaking change in the public API of the oci-spec crate. This commit fixes the issue.

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 10, 2024
@Mossaka
Copy link
Contributor Author

Mossaka commented Jul 10, 2024

Any insights on why the integration tests failed? @utam0k

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jul 11, 2024

Hey, the basic check CI needs to be fixed for clippy warnings. As for the integration tests, they can be flacky, so next commit might pass.

there is a breaking change in the public API of the oci-spec crate. This commit fixes the issue.

Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
@Mossaka
Copy link
Contributor Author

Mossaka commented Jul 12, 2024

@YJDoc2 rebased this PR and it seems like all the checks have passed. This will help #2848 to pass the checks as well.

@utam0k utam0k merged commit 1026225 into containers:main Jul 14, 2024
28 checks passed
@github-actions github-actions bot mentioned this pull request Jul 14, 2024
@Mossaka Mossaka deleted the update-oci-spec branch July 15, 2024 15:20
@github-actions github-actions bot mentioned this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants