Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch oci-spec-rs from crates.io. #329

Closed
guni1192 opened this issue Sep 25, 2021 · 2 comments
Closed

Fetch oci-spec-rs from crates.io. #329

guni1192 opened this issue Sep 25, 2021 · 2 comments
Assignees
@yihuaf

Comments

@guni1192
Copy link
Contributor

Fetch oci-spec-rs from git, not from crates.io.
We are using git hash to modify the version of oci-spec-rs.
This is because a version incorporating this PR (containers/oci-spec-rs#69) has not yet been released.
We will update the minor version of oci-spec-rs as soon as it is released.

ref: #303
@guni1192 guni1192 mentioned this issue Sep 25, 2021
Merged
@yihuaf yihuaf mentioned this issue Sep 27, 2021
Closed
4 tasks
@yihuaf yihuaf self-assigned this Oct 4, 2021
@yihuaf
Copy link
Collaborator

yihuaf commented Oct 8, 2021 •
edited

@utam0k I was thinking may be we should maintain git commit hash for this until oci-spec-rs is stable? It seems that we constantly are finding kinks to iron out between the spec repo and youki. This allows us to periodically to update the oci-spec-rs to the tip of master, instead of waiting for a new version to be released.

@utam0k
Copy link
Member

utam0k commented Oct 8, 2021

I agree with you 👍

@yihuaf yihuaf closed this as completed Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yihuaf yihuaf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@guni1192 @utam0k @yihuaf