New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated oci-spec-rs to 0.5.1 or later #303
Conversation
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
@utam0k
|
Oh... Can I ask you to implement it in this PR? |
@utam0k I see. I'll try it. |
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 71.14% 70.69% -0.46%
==========================================
Files 46 46
Lines 6828 6702 -126
==========================================
- Hits 4858 4738 -120
+ Misses 1970 1964 -6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a consideration in the future, we should implement From spec to spec builder, so we don't have boilerplate code to copy a spec. It is error prune since we have to copy every field with a default builder.
if let Some(pids) = &controller_opt.resources.pids { | ||
return Some(pids); | ||
} | ||
fn needs_to_handle<'a>(_controller_opt: &'a ControllerOpt) -> Option<&'a Self::Resource> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing.
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
Signed-off-by: Takashi IIGUNI <iiguni.tks@gmail.com>
ref: #299
Apply builder pattern.
Getter
Builder