Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libcontainer] Integrate WasmEdge Runtime #1320

Merged
merged 17 commits into from Nov 30, 2022
Merged

[libcontainer] Integrate WasmEdge Runtime #1320

merged 17 commits into from Nov 30, 2022

Conversation

apepkuss
Copy link
Contributor

@apepkuss apepkuss commented Nov 6, 2022 •
edited by gitpod-io bot

In this PR, WasmEdgeExecutor is introduced into libcontainer for integrating WasmEdge Runtime.

@apepkuss apepkuss changed the title [WIP][libcontainer] Integrate WasmEdge Runtime [libcontainer] Integrate WasmEdge Runtime Nov 7, 2022
@apepkuss apepkuss marked this pull request as ready for review November 7, 2022 14:30
utam0k
utam0k reviewed Nov 8, 2022
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 🙏

crates/libcontainer/Cargo.toml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022 •
edited

Codecov Report

Merging #1320 (44f1c13) into main (ca06465) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1320      +/-   ##
==========================================
- Coverage   68.81%   68.80%   -0.02%     
==========================================
  Files         119      119              
  Lines       12586    12664      +78     
==========================================
+ Hits         8661     8713      +52     
- Misses       3925     3951      +26

@Furisto
Copy link
Member

Furisto commented Nov 13, 2022

@apepkuss There is a build failure. Can you check?

@apepkuss
Copy link
Contributor Author

@apepkuss There is a build failure. Can you check?

Thanks for your message. I checked the issues in the failed workflows: one is a clippy issue caused by an unstable feature, and the other is the wasmedge library was not installed in the CI environment so the wasmedge-sdk crate cannot find the dependency. We'll fix them asap. Thanks a lot!

@utam0k
Copy link
Member

utam0k commented Nov 23, 2022

@apepkuss May I ask you to update the documentation for the developer and users? Another PR is fine.
https://containers.github.io/youki/user/webassembly.html

@apepkuss
Copy link
Contributor Author

@apepkuss May I ask you to update the documentation for the developer and users? Another PR is fine. https://containers.github.io/youki/user/webassembly.html

@utam0k Sure. I'll try to update the document in this PR. Thanks!

@utam0k
Copy link
Member

utam0k commented Nov 23, 2022 •
edited

@apepkuss May I ask you to update the documentation for the developer and users? Another PR is fine. https://containers.github.io/youki/user/webassembly.html

@utam0k Sure. I'll try to update the document in this PR. Thanks!

Thanks 🙏

@apepkuss
Also, I will mention this topic on KubeDay Japan12. What do you think? If you have something to say, please let me know via Discord or Twitter DM, and I'll think of something.

Footnotes

  1. https://events.linuxfoundation.org/kubeday-japan/ ↩

  2. https://sched.co/1C8lS ↩

rumpl and others added 15 commits November 25, 2022 17:42
@rumpl @apepkuss
wasmedge
6cf4107 
Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
@apepkuss
refactor(libcontianer): refactor wasmedge executor
4e50371 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
doc(webassembly): update build section with wasmedge
6a6ad10 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
chore: add wasm-wasmedge feature
0d386aa 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
refactor(libcontainer)!: rename wasmedge executor
1c8eea1 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
feat(libcontainer): introduce WasmEdgeExecutor into ExecutorManager
e23e441 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
refactor(libcontainer): remove comments
8f39b22 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
chore(libcontainer): remove wasmedge-sys and wasmedge-types dependecies
1be10c6 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
chore: update wasmedge version
95b8338 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
fix(libcontianer): fix the wrong argument value
2ce3fef 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
chore(libcontainer): update dependency
2110378 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
chore(libcontainer): update Cargo.lock
e1118eb 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
fix(libcontainer): fix a rebase issue
cc1a232 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
fix(libcontainer): fix clippy issues
5b17af1 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
chore(libcontainer): update dependency
b74bbf5 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
Copy link
Contributor Author

@apepkuss May I ask you to update the documentation for the developer and users? Another PR is fine. https://containers.github.io/youki/user/webassembly.html

@utam0k Sure. I'll try to update the document in this PR. Thanks!

Thanks 🙏

@apepkuss Also, I will mention this topic on KubeDay Japan12. What do you think? If you have something to say, please let me know via Discord or Twitter DM, and I'll think of something.

Footnotes

  1. https://events.linuxfoundation.org/kubeday-japan/ ↩
  2. https://sched.co/1C8lS ↩

@utam0k Thanks for your invitation. I believe my colleague has already contacted you. Please discuss the details with my colleague. Thanks again!

@apepkuss
Copy link
Contributor Author

@utam0k @Furisto I've made some changes in this PR for the previous issues. Please review the latest changes. Thanks a lot!

@utam0k
Copy link
Member

utam0k commented Nov 25, 2022

@utam0k @Furisto I've made some changes in this PR for the previous issues. Please review the latest changes. Thanks a lot!

It seems that the ci got failed. I guess you missed something to install in the ci.

stderr:
/tmp/rustdoctestxV6caY/rust_out: error while loading shared libraries: libwasmedge.so.0: cannot open shared object file: No such file or directory

@apepkuss
Copy link
Contributor Author

@utam0k @Furisto I've made some changes in this PR for the previous issues. Please review the latest changes. Thanks a lot!

It seems that the ci got failed. I guess you missed something to install in the ci.

stderr:
/tmp/rustdoctestxV6caY/rust_out: error while loading shared libraries: libwasmedge.so.0: cannot open shared object file: No such file or directory

@utam0k Yeah, I also noticed the error and am working on it. I'll let you know if the issue is fixed. Thanks!

@apepkuss
ci(main): add the path to libwasmedge
e6c1e77 
Signed-off-by: Xin Liu <sam@secondstate.io>
@apepkuss
doc(webassembly): update wasmedge
44f1c13 
Signed-off-by: Xin Liu <sam@secondstate.io>
utam0k
utam0k reviewed Nov 30, 2022
View reviewed changes
docs/src/user/webassembly.md
- Run `build.sh` with `-f wasm-wasmedge` option.

```console
./script/build.sh -o -r . -f wasm-wasmedge
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @YJDoc2 We should update this command in another PR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, I'll fix it in #1383 👍

utam0k
utam0k approved these changes Nov 30, 2022
View reviewed changes
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯

@utam0k utam0k merged commit 997bc43 into containers:main Nov 30, 2022
@apepkuss
Copy link
Contributor Author

@utam0k Thank you very much for the review!

@utam0k utam0k mentioned this pull request Nov 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YJDoc2 YJDoc2 YJDoc2 left review comments

@utam0k utam0k utam0k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@apepkuss @codecov-commenter @Furisto @utam0k @YJDoc2 @rumpl