Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trivial] Remove the metadata semvar causing a warning. #1744

Merged
merged 1 commit into from Mar 31, 2023

Conversation

yihuaf
Copy link
Collaborator

@yihuaf yihuaf commented Mar 29, 2023

No description provided.

Signed-off-by: Eric Fang <yihuaf@unkies.org>
@yihuaf yihuaf marked this pull request as ready for review March 29, 2023 18:20
@yihuaf yihuaf self-assigned this Mar 29, 2023
@yihuaf yihuaf requested review from utam0k and YJDoc2 March 29, 2023 18:20
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 30, 2023

Hey, I have seen the warning from this, but the crate itself adds this metadata, as we can see in install section https://crates.io/crates/libbpf-sys . I think the second part maps to the libbpf against which this is built.
Would it be a good idea to remove (not that this should change anything compilation-wise, as cargo ignores it anyways)

@yihuaf
Copy link
Collaborator Author

yihuaf commented Mar 30, 2023

Hey, I have seen the warning from this, but the crate itself adds this metadata, as we can see in install section https://crates.io/crates/libbpf-sys . I think the second part maps to the libbpf against which this is built. Would it be a good idea to remove (not that this should change anything compilation-wise, as cargo ignores it anyways)

I filed libbpf/libbpf-sys#58 to clarify with the lib author. If I am understanding correctly, the metadata version is used as a human readable indicator for the version of upstream of libbpf used. So it should be safe to remove from the cargo.toml since as you mentioned cargo ignores it.

@yihuaf
Copy link
Collaborator Author

yihuaf commented Mar 31, 2023

@YJDoc2 Confirmed with the libbpf author that the metadata can be ignored safely in the cargo.toml. Reference: libbpf/libbpf-sys#58 (comment)

Copy link
Collaborator

@YJDoc2 YJDoc2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@YJDoc2 YJDoc2 merged commit 25cff9b into containers:main Mar 31, 2023
11 checks passed
@yihuaf yihuaf deleted the yihuaf/fix branch March 31, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants