Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch codespace from gitpod #2306

Merged
merged 1 commit into from Aug 29, 2023
Merged

Conversation

utam0k
Copy link
Member

@utam0k utam0k commented Aug 25, 2023

Fix: #2286

Signed-off-by: utam0k <k0ma@utam0k.jp>
@codecov-commenter
Copy link

Codecov Report

Merging #2306 (ddb4d88) into main (39f65aa) will decrease coverage by 0.12%.
Report is 35 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2306      +/-   ##
==========================================
- Coverage   64.99%   64.88%   -0.12%     
==========================================
  Files         129      129              
  Lines       15153    15179      +26     
==========================================
  Hits         9849     9849              
- Misses       5304     5330      +26     

@utam0k utam0k added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 27, 2023
@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 28, 2023

Hey can I ask you to add some info about how to do setup for dev containers and how we can use them locally/remotely ?

@utam0k
Copy link
Member Author

utam0k commented Aug 28, 2023

@YJDoc2 You can open this button!
image

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Aug 29, 2023

Oh, didn't know that. In that case, LGTM 👍 This is primarily for dev purposes, so we can always iterate and update as needed later.

@YJDoc2 YJDoc2 merged commit 9516fb2 into containers:main Aug 29, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch Codespaces from Gitpod
3 participants