Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting no_pivot_root for create and run command #2597

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Vanient
Copy link

@Vanient Vanient commented Dec 26, 2023

This pr supports setting no_pivot_root for create and run command,
what no_pivot means refer to https://github.com/opencontainers/runc/blob/main/man/runc-create.8.md
As pivot_root could not work with initramfs, youki create failed when container rootfs is on initramfs, so supporting to disable it and replace with chroot is needed.

Signed-off-by: Vanient <xiadanni1@huawei.com>
@utam0k
Copy link
Member

utam0k commented Dec 26, 2023

@Vanient Thanks for your first contribution 🙏 May I ask you to write the description in PR. This is the example template for you:

## What this PR does / why we need it:

## Which issue(s) this PR fixes:

@Vanient
Copy link
Author

Vanient commented Dec 27, 2023

@Vanient Thanks for your first contribution 🙏 May I ask you to write the description in PR. This is the example template for you:

## What this PR does / why we need it:

## Which issue(s) this PR fixes:

ok I have updated the description~

@codecov-commenter
Copy link

Codecov Report

Merging #2597 (f16612f) into main (6f1db26) will decrease coverage by 0.03%.
Report is 7 commits behind head on main.
The diff coverage is 9.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2597      +/-   ##
==========================================
- Coverage   65.88%   65.86%   -0.03%     
==========================================
  Files         133      133              
  Lines       16819    16829      +10     
==========================================
+ Hits        11081    11084       +3     
- Misses       5738     5745       +7     

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 2, 2024

Hey, would it be possible to add tests for this flag?

@Vanient
Copy link
Author

Vanient commented Jan 5, 2024

Hey, would it be possible to add tests for this flag?

I thinked about to add tests for this but found a little difficult to add in any file, do you have any good idea...

@utam0k
Copy link
Member

utam0k commented Jan 6, 2024

@Vanient, I appreciate you giving it a try 🙏 This doc may help you.
https://containers.github.io/youki/developer/e2e/rust_oci_test.html

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Jan 21, 2024

Hey @Vanient , let me know if you need any help in adding the tests here!

@YJDoc2
Copy link
Collaborator

YJDoc2 commented Mar 11, 2024

@Vanient , are you still working on this? If you are busy with something else, and cannot work on this, that is fine, just let us know so we can work accordingly. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants