Fix integration test validation CI, make io_priority test conditional #2707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
|
when this pr opencontainers/runc#3783 merge after, we should delete |
Not just PR merge, this also needs to be released by runc in one of their releases. For example, right now they have domainname support on their main, but not in any released versions. Once they release any version with the PR code, we can update runc version in our CI and change the rust test code to previous. |
Merged
lengrongfu
approved these changes
Feb 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the name change of integration test to contest, this CI file was missed, and as a result we didn't validate the tests even when there was a change in them.
I think implementation of io_priority in runc is still pending on opencontainers/runc#3783 , so made them condition with runc check.