selinux: write xattr related codes. #2825
Conversation
|
I'll visit this PR in a couple of days. Please give me some time. |
| let size = rfs::getxattr(fpath, attr, &mut buf) | ||
| .map_err(|e| XattrError::GetXattr(e.to_string()))?; | ||
| let mut value = String::from_utf8_lossy(&buf[..size]).into_owned(); | ||
| if (!value.is_empty()) && (value.ends_with('\x00')) { |
There was a problem hiding this comment.
Shouldn't the \x00 be checked and the buffer size adjusted if it isn't termination.
There was a problem hiding this comment.
Fixed it. Is this implementation same as your intention?
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2825 +/- ##
==========================================
+ Coverage 66.27% 66.29% +0.02%
==========================================
Files 131 131
Lines 16784 16794 +10
==========================================
+ Hits 11123 11134 +11
+ Misses 5661 5660 -1 |
@utam0k should we remove the codecov bot for now? We are not enforcing the coverage value in CI, and also not maintaining a required threshold for it. |
This is an experimental crate. I'll implement a selinux crate step-by-step.
In this PR, I implemented functions related to xattr.
ref: #2718 #2800