Implemented util function to test in child process #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #345 +/- ##
==========================================
+ Coverage 70.38% 70.45% +0.07%
==========================================
Files 46 46
Lines 6790 6844 +54
==========================================
+ Hits 4779 4822 +43
- Misses 2011 2022 +11 |
utam0k
reviewed
Sep 29, 2021
Cargo.toml
Outdated
| @@ -50,6 +50,7 @@ tabwriter = "1" | |||
| fastrand = "1.4.1" | |||
| crossbeam-channel = "0.5" | |||
| seccomp = { version = "0.1.0", path = "./seccomp" } | |||
| ipc-channel = "0.15.0" | |||
There was a problem hiding this comment.
I'd like to make ipc-channel depend on only dev-dependencies, is it possible?
There was a problem hiding this comment.
Yes it can be done. Take a look at the latest commit. I may want to use ipc-channel in other part of Youki's code, but let's keep it as dev-dependencies for now, and discuss this when we get there.
|
I've been trying to work on this issue too to see if I can't do something about it. I agree with you about putting this processing together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have many cases where we want to write unit test in a child process, because the functions we want to test will change the underlying OS state. Since cargo test runs in a single process, we have to fork unto child process to run functions. Before, using only fork, we can only pass
intback to parent process. Usingipc-channelcrate, we can pass richer test results back to the parent process so the error message is much clearer.I only made change to seccomp tests as an example. Let me know what you think.