Add rootless option for spec #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reference: runc |
yihuaf
reviewed
Oct 1, 2021
src/commands/spec_json.rs
Outdated
| for ns in spec | ||
| .linux() | ||
| .as_ref() | ||
| .unwrap() |
There was a problem hiding this comment.
Can we not use unwrap? I know it may take a few more line to return results, but let's avoid unwrap in general.
There was a problem hiding this comment.
Can we not use
unwrap? I know it may take a few more line to return results, but let's avoid unwrap in general.
how about use unwrap_or ?
Codecov Report
@@ Coverage Diff @@
## main #350 +/- ##
==========================================
- Coverage 70.45% 69.33% -1.13%
==========================================
Files 46 48 +2
Lines 6844 7118 +274
==========================================
+ Hits 4822 4935 +113
- Misses 2022 2183 +161 |
yihuaf
reviewed
Oct 2, 2021
utam0k
reviewed
Oct 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will generate a config.json for rootless.