make the rootless code testable #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #634 +/- ##
==========================================
+ Coverage 69.93% 70.74% +0.81%
==========================================
Files 82 84 +2
Lines 10948 11111 +163
==========================================
+ Hits 7656 7861 +205
+ Misses 3292 3250 -42 |
yihuaf
approved these changes
Feb 6, 2022
| @@ -96,6 +97,26 @@ impl<'a> From<&'a Linux> for Rootless<'a> { | |||
| } | |||
| } | |||
|
|
|||
| #[cfg(not(test))] | |||
There was a problem hiding this comment.
This is a super cool idea. Can you add some comments for future us on how this is used in the unit tests?
There was a problem hiding this comment.
I'm sorry but I couldn't imagine what kind of comments you want 馃檱 Please let me more concreate.
Co-authored-by: Eric Fang <github@accounts.unkies.org>
utam0k
force-pushed
the
improvement/rootless
branch
from
b13f473
to
d20ec86
Compare
Furisto
approved these changes
Feb 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃挭
Related: #279