Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure namespaces are entered in correct order #674

Merged
merged 1 commit into from Jan 30, 2022

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Jan 29, 2022

During exec namespaces were entered in arbitrary order. This leads to a high probability of the exec call failing because once a mount namespace is entered which contains /proc mounted by a process from a different pid namespace, we are unable to locate the rest of the namespaces we want to enter.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022

Codecov Report

Merging #674 (6c0909a) into main (e86f2b4) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

@@            Coverage Diff             @@
##             main     #674      +/-   ##
==========================================
- Coverage   69.64%   69.63%   -0.01%     
==========================================
  Files          84       84              
  Lines       10990    10990              
==========================================
- Hits         7654     7653       -1     
- Misses       3336     3337       +1     

Signed-off-by: Furisto <24721048+Furisto@users.noreply.github.com>
Copy link
Member

@utam0k utam0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@utam0k utam0k merged commit f402da8 into containers:main Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants